Fix a bug where JWT on relative paths #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpatrick
approved these changes
May 30, 2019
|
Any prediction when this is going to be merged & released ? |
|
Are you aware this a duplicate of pull request #542 ? |
|
How is this a duplicate of #542 ? |
|
Sorry, commented on wrong issue. |
|
Was meant for PR #600 |
davidpatrick
suggested changes
Jun 5, 2019
src/jwt.interceptor.ts
Outdated
| @@ -40,15 +40,15 @@ export class JwtInterceptor implements HttpInterceptor { | |||
|
|
|||
| isWhitelistedDomain(request: HttpRequest<any>): boolean { | |||
| const requestUrl: any = parse(request.url, false, true); | |||
|
|
|||
| const requestHost: string = requestUrl.host || (location && location.host) | |||
There was a problem hiding this comment.
In order to not block potential universal support, can we do a typeof check here on location?
There was a problem hiding this comment.
typeof location === 'object'
???
Nevermind, just forgot that this is Typescript, sorry about dat :(
davidpatrick
approved these changes
Jun 6, 2019
stevehobbsdev
pushed a commit
that referenced
this pull request
Jun 27, 2019
Reverting this merge as it introduces an undesirable change to the default whitelisting behaviour. See 0287bcb#r34107408 This reverts commit 33e441f, reversing changes made to 5f8db7f.
stevehobbsdev
pushed a commit
that referenced
this pull request
Jun 28, 2019
Revert "Merge pull request #604 from driverpt/patch-1"
|
@stevehobbsdev , that is the correct behaviour. If you're redirecting to an S3 Bucket, since the initial request to the server has no Host, it will always add the JWT Headers, which will result in 403 Errors from AWS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603