Fixing minor code quality issues #231
Conversation
| @@ -4,8 +4,6 @@ | |||
| [](https://travis-ci.org/auth0/auth0-PHP) | |||
| [](https://codeclimate.com/github/auth0/auth0-PHP) | |||
| [](https://codeclimate.com/github/auth0/auth0-PHP/coverage) | |||
| [](https://www.versioneye.com/php/auth0:auth0-php) | |||
There was a problem hiding this comment.
| @@ -1,4 +1,13 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Summary of changes:
- Spacing and indenting (automatically with
phpcbf) - Docblocks
- Private properties get a
_prefix - Line length = 85
| @@ -49,7 +49,7 @@ public function testAll() { | |||
|
|
|||
| $this->afterCreate($created); | |||
|
|
|||
| $client3 = $client->update($this->getId($created), $this->getUpdateBody()); | |||
joshcanhelp
changed the title
| @@ -4,8 +4,6 @@ | |||
| [](https://travis-ci.org/auth0/auth0-PHP) | |||
| [](https://codeclimate.com/github/auth0/auth0-PHP) | |||
| [](https://codeclimate.com/github/auth0/auth0-PHP/coverage) | |||
| [](https://www.versioneye.com/php/auth0:auth0-php) | |||
| [](http://hhvm.h4cc.de/package/auth0/auth0-php) | |||
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| class BlacklistsTest extends ApiTests { | |||
|
|
|||
| private $domain; | |||
There was a problem hiding this comment.
How come no _ for this private property, or tests out of scope in this refactor?
There was a problem hiding this comment.
@cocojoe - I ran the phpcs/phpcbf against all the files and the list was so long that my terminal couldn't show it all 😆 so I just used it on src/API/Authentication.php (inspected the rest) to see how much work as involved. Answer is: a lot but I think it's worth it. I would like to see 5.x.x "finished" before it's archived and I see this as part of that.
|
@cocojoe - Approved? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Ran through Code Inspector in PhpStorm and PHP CodeSniffer