Add pagination and tests to Resource Servers #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Jul 9, 2018
| */ | ||
| public function create($client_id, $data) | ||
| public function create($identifier, array $data) |
There was a problem hiding this comment.
Better param name, not breaking
There was a problem hiding this comment.
$client_id was never used before ? 😆 Backwards compatibility seems fine.
There was a problem hiding this comment.
Yeah, param was there but not used anywhere in the method 🤷♂️
joshcanhelp
force-pushed
the
add-pagination-res-servers
branch
from
3446755 to
fb8a560
Compare
cocojoe
approved these changes
Jul 12, 2018
| */ | ||
| public function create($client_id, $data) | ||
| public function create($identifier, array $data) |
There was a problem hiding this comment.
$client_id was never used before ? 😆 Backwards compatibility seems fine.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$pageand$per_pageparameters to\Auth0\SDK\API\Management\ResourceServers::getAll()