Add Jobs endpoint tests #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
add-jobs-tests
branch
from
05557ec to
7b849eb
Compare
joshcanhelp
force-pushed
the
add-jobs-tests
branch
from
7b849eb to
cd4e021
Compare
lbalmaceda
reviewed
Sep 18, 2019
| $headers = $api->getHistoryHeaders(); | ||
| $this->assertEquals( 'Bearer __api_token__', $headers['Authorization'][0] ); | ||
| $this->assertEquals( self::$expectedTelemetry, $headers['Auth0-Client'][0] ); | ||
| $this->assertStringStartsWith( 'multipart/form-data', $headers['Content-Type'][0] ); |
There was a problem hiding this comment.
why starts with vs equals? also, curious on why this request is using form vs body?
There was a problem hiding this comment.
why starts with vs equals?
The URL includes the query parameters and I just want the URL here.
curious on why this request is using form vs body?
Import users endpoint requires a file to be posted.
| // Get a single, active database connection. | ||
| $default_db_name = 'Username-Password-Authentication'; | ||
| $get_connection_result = $api->connections->getAll( 'auth0', ['id'], true, 0, 1, ['name' => $default_db_name] ); | ||
| sleep(0.2); |
There was a problem hiding this comment.
why is this required? We should be lowering the time each run takes, because of the CI OSS plan limits. 🧀 🐀
There was a problem hiding this comment.
Management API limits
lbalmaceda
approved these changes
Sep 19, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add tests for the Management API Jobs endpoint . This SDK does not yet cover all Jobs endpoints, hence the limited tests.
References
Tests for #354
Testing