-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic jwks url by discovery document #417 #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
I have 2 important changes here. Also, please revert your whitespace changes here, as it makes it difficult to review what has actually changed. Also please use the PR template that is provided.
@joshcanhelp the whitespaces are added/removed by the command "phpcbf", if you want I can restore them. |
For this project, use
PHPCS definitely needs some work here but that should happen in different PR, not this one. |
same result on my branch, maybe phpcbf not fix (and check) the spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mabuonomo - Sorry but can you revert all the style and naming changes in this PR? Most of the changes here are noise and renaming requestJwks
-> request
is a breaking change for anyone extending that class.
I would suggest adding a new class for the discovery doc (aka issuer) as that information can be used in a number of different places, not just for the JWKS.
@mabuonomo - Just FYI ... we're doing some work with the JWKS fetching in #426 that should address your custom JWKS issue. We'll add discovery at some point but that will probably come with a new |
Addressed in #426 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi, this PR is linked to issue #417