Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding InMemory storage for tests #544

Merged
merged 4 commits into from
Aug 21, 2021
Merged

Adding InMemory storage for tests #544

merged 4 commits into from
Aug 21, 2021

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Aug 20, 2021

When writing functional tests, I want to make sure no cookie is written. Adding an InMemoryStorage will help me create an SdkConfiguration that do not mess with the global state.

This is a class that I would need in every application, hence I thought it to be good to add in to the SDK.

Changes

References

None

Testing

Use PHPUnit

Contributor Checklist

@Nyholm Nyholm requested a review from a team as a code owner August 20, 2021 23:00
Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@evansims evansims merged commit 26e48df into auth0:main Aug 21, 2021
@Nyholm
Copy link
Contributor Author

Nyholm commented Aug 21, 2021

Wohoo. Thank you for merging

@Nyholm Nyholm deleted the in-memory branch August 21, 2021 05:34
@evansims evansims mentioned this pull request Sep 3, 2021
2 tasks
@evansims evansims added this to the 8.0.0 milestone Sep 3, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants