-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2752] Expand test coverage and finish migration to Pest framework #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of other storage mediums.
jimmyjames
requested changes
Sep 1, 2021
jimmyjames
approved these changes
Sep 1, 2021
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Although this PR is large and intimidating to look it, it doesn't change anything regarding the logic of the SDK. Its purpose is to expand the unit tests to 100% coverage of the v8 SDK, and to update our unit test syntax to the modern Pest format we had already adopted with our newer test additions in v8.
The highlighted intent of this pull request:
pest-plugin-parallel
plugin for improved performance by running tests in parallelhyperf/event
to dev dependencies for thorough PSR-4 unit testingOther tweaks in this PR of note:
InMemoryStorage
class toMemoryStore
to match the naming convention of other storage classes. As it is new to v8, this is not a breaking change.httpClient
var in theManagementEndpoint
class now use the publicgetHttpClient()
method to ensure the HTTP client is properly instantiated before its use.Auth0\SDK\API\Management\Tenants
to match the naming conventions of other Management classes, which follow the naming conventions of the endpoints themselves.handleInvitation()
on theAuth0\SDK\Auth0
in which the login URL was not properly returned.clear()
onAuth0\SDK\Auth0
to opt out of clearing transient storage, in the event we're only needing to wipe out a stale user session to make way for a new one during code exchange.getRequestParameter()
onAuth0\SDK\Auth0
to support applying different internal PHP sanitization filters.SdkConfiguration
which is now handled by improved type checking inConfigurableMixin
.TokenVerifier
for unit testing purposes.Toolkit
in regard to object referencing.Testing
Tests can be run locally using
composer run tests
, or in a Docker container usingcomposer run tests:docker
.Contributor Checklist