Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2988] Fix psalm test warnings around specificity of integer types and positive values #586

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

evansims
Copy link
Member

@evansims evansims commented Dec 8, 2021

Changes

This PR addresses some new test warnings introduced by upgraded Psalm test suite rules.

References

  • Addresses an upstream change introduced in Psalm with PR 6861, cut later with a minor release, that is causing our test suite to fail. PR requires positive integers for sleep methods.
  • Addresses an upstream changed introduced in Psalm with PR 6824, cut later in a minor release, that is causing our test suite to fail. PR requires $_SESSION superglobal be checked for it's state.

Testing

Run standard tests using composer run tests or more specifically composer run tests:psalm before this PR patch and after to see the Psalm warnings resolved. Tests continue to otherwise pass at 100% coverage.

Contributor Checklist

@evansims evansims marked this pull request as ready for review December 8, 2021 18:16
@evansims evansims requested a review from a team as a code owner December 8, 2021 18:16
@evansims evansims changed the title Fix psalm test warnings around specificity of integer types and positive values [SDK-2988] Fix psalm test warnings around specificity of integer types and positive values Dec 8, 2021
@evansims evansims mentioned this pull request Dec 8, 2021
2 tasks
@evansims evansims merged commit f044d74 into main Dec 8, 2021
@evansims evansims deleted the tests/fix-warnings branch December 8, 2021 18:32
@evansims evansims mentioned this pull request Dec 13, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants