Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3081] Auth0->renew() should update all appropriate session details after a successful token refresh #593

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

evansims
Copy link
Member

This PR resolves an issue where the local cache of the token expiration timestamp (expires_in) is not properly updated after a refresh token is used, causing the SDK to wrongly continue reporting the token as expired.

@evansims evansims changed the title Fix: Updated expires_in not applied to the local cache of the token after a token is refreshed [SDK-3081] Fix: Updated expires_in not applied to the local cache of the token after a token is refreshed Jan 25, 2022
@evansims evansims marked this pull request as ready for review January 25, 2022 01:52
@evansims evansims requested a review from a team as a code owner January 25, 2022 01:52
@evansims evansims changed the title [SDK-3081] Fix: Updated expires_in not applied to the local cache of the token after a token is refreshed [SDK-3081] Fix: Update session properties after a token is refreshed Jan 25, 2022
Copy link

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@evansims evansims merged commit 3797004 into main Jan 25, 2022
@evansims evansims deleted the fix/token-expiration-not-updated-with-token-refresh branch January 25, 2022 20:12
@evansims evansims changed the title [SDK-3081] Fix: Update session properties after a token is refreshed [SDK-3081] Auth0->renew() should update all appropriate session details after a successful token refresh Jan 25, 2022
@evansims evansims mentioned this pull request Jan 25, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants