Add network exception to management (#603) #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 I don't seem to be able to trigger that test failure locally with Also the |
evansims
approved these changes
Mar 13, 2022
There was a problem hiding this comment.
Hey @sepiariver 👋 Thanks for these contributions! Looks great. I kicked our test suite to fix the infection error (it randomly breaks sometimes). Really appreciate the help! I'll cut a new release with these changes next week sometime
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A per issue #603 this PR adds a method to
Auth0\SDK\Exception\NetworkExceptionin order to raise errors returned by the API when exchanging credentials for a management token.For users of the SDK, they may save a lot of time debugging, because previously the error was (mis)represented as a
Auth0\SDK\Exception\ConfigurationExceptionReferences
#603
Resolves #603
Testing
composer testspass. A new unit test is included in this PR. All php version-specific tests pass.Contributor Checklist