[SDK-3631] Defer/batch "Set-Cookie" headers at login() for transient cookies, and clear()
#641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
approved these changes
Sep 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Building on the previous implementation of “Set-Cookie” header batching/deference during exchange(), this tweak optimizes in the same manner for clear() and login() calls. Critically, this resolves a common issue for apps behind load balancers like AWS Elastic Load Balancing where there is a hard limit on cookie header sizes, but the change is beneficial for all apps in reducing network overhead.
References
See internal ticket SDK-3631
Testing
See GitHub workflow results.
Contributor Checklist