-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3646] Reliability and performance improvements to CookieStore #649
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 996 1006 +10
===========================================
Files 65 65
Lines 3636 3677 +41
===========================================
+ Hits 3636 3677 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…to CookieStore (#649) * Improve CookieStore reliability under some circumstances * Adjust tests to reflect CookieStore changes * Ignore code coverage on untestable circumstances * Remove leftover debug code * Temporarily lock dependency due to break upstream * Code quality improvements * Additional improvements * Expand tests
Changes
This PR:
Note that these changes require structural changes to session cookies. Upon updating your application with these merged changes, some users may need to reauthenticate to replace old session cookies with the new format.
This PR also contains unrelated changes to address failing unit tests necessary for this PR to pass review:
References
See internal ticket SDK-3646
Testing
Contributor Checklist