Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3719] Fix PHP 8.0+ SdkConfiguration named arguments usage #654

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented Oct 18, 2022

Changes

This PR addresses an issue with the SdkConfiguration class when named arguments are used for configuration in PHP 8.0+ — specifically, validation of those properties when set with named arguments.

References

Resolves auth0/laravel-auth0#319

Testing

Contributor Checklist

@evansims evansims added this to the 8.3.2 milestone Oct 18, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 95.64% // Head: 95.32% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (d2b98f1) compared to base (bf777e2).
Patch coverage: 77.52% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #654      +/-   ##
============================================
- Coverage     95.64%   95.32%   -0.32%     
- Complexity     1159     1204      +45     
============================================
  Files            65       65              
  Lines          4066     4153      +87     
============================================
+ Hits           3889     3959      +70     
- Misses          177      194      +17     
Impacted Files Coverage Δ
src/Configuration/SdkConfiguration.php 74.95% <77.52%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@evansims evansims marked this pull request as ready for review October 18, 2022 23:43
@evansims evansims requested a review from a team as a code owner October 18, 2022 23:43
@evansims evansims merged commit 2b2c123 into main Oct 19, 2022
@evansims evansims deleted the fix/named-properties-validation branch October 19, 2022 01:20
github-actions bot pushed a commit that referenced this pull request Oct 19, 2022
@evansims evansims mentioned this pull request Oct 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error setting Laravel Session Storage
3 participants