Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Integration Testcases #1052

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Fix Integration Testcases #1052

merged 3 commits into from
Aug 8, 2024

Conversation

developerkunal
Copy link
Contributor

🔧 Changes

  • Fixed test cases for Custom Domain due to issues in tenant.

📚 References

  • Management API doesn't let us use custom-domain.com for our Tenant.

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal developerkunal requested a review from a team as a code owner August 7, 2024 10:47
duedares-rvj
duedares-rvj previously approved these changes Aug 7, 2024
Copy link
Contributor

@duedares-rvj duedares-rvj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.34%. Comparing base (d1702f7) to head (987eaad).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files          94       94           
  Lines       12781    12781           
=======================================
  Hits         9247     9247           
  Misses       2984     2984           
  Partials      550      550           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal merged commit f5c05e5 into main Aug 8, 2024
8 checks passed
@developerkunal developerkunal deleted the fix-integration-tests branch August 8, 2024 05:27
@developerkunal developerkunal restored the fix-integration-tests branch September 2, 2024 12:14
@developerkunal developerkunal deleted the fix-integration-tests branch September 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants