Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0CLI-49: add initial custom-domains support #65

Merged
merged 5 commits into from
Jan 27, 2021
Merged

Conversation

rene00
Copy link
Contributor

@rene00 rene00 commented Jan 27, 2021

Description

This PR adds initial Custom Domains support to auth0-cli.

It also bumps briandowns/spinner to latest version to resolve a race condition issue (see briandowns/spinner#99). I was hitting this race condition with the unit tests that accompany this PR.

List all custom domains:

$ auth0 custom-domains list

Create a new custom domain:

$ auth0 custom-domains create --domain example.org --type auth0_managed_certs --verification-method txt

Get a custom domain:

$ auth0 custom-domains get --custom-domain-id myCustomDomainID

Verify a custom domain:

$ auth0 custom-domains verify --custom-domain-id myCustomDomainID

Delete a custom domain:

$ auth0 custom-domains delete --custom-domain-id myCustomDomainID

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

`make mocks` will generate mocks.
@rene00 rene00 self-assigned this Jan 27, 2021
@rene00 rene00 changed the title A0CLI-49: add custom-domains support A0CLI-49: add initial custom-domains support Jan 27, 2021
@rene00 rene00 force-pushed the a0cli-49-custom-domains branch 2 times, most recently from ce67da1 to 271d427 Compare January 27, 2021 05:40
@rene00 rene00 force-pushed the a0cli-49-custom-domains branch from 271d427 to 64c0d40 Compare January 27, 2021 05:44
@rene00 rene00 marked this pull request as ready for review January 27, 2021 05:44
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mate!

@rene00 rene00 merged commit d01a0a3 into main Jan 27, 2021
@rene00 rene00 deleted the a0cli-49-custom-domains branch January 27, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants