Fix timezone issue in Android Credentials Manager handler #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
The Android
SaveCredentialsRequestHandler
receives anexpiresAt
UTC string date from the Dart layer. This date string should be parsed as UTC, but instead it gets parsed using the default timezone. Thus, the default timezone's offset gets added to the date, resulting in an incorrectCredentials.expiresAt
value.This happens because no timezone was specified for the
SimpleDateFormat
parser, and as suchTimeZone.getDefault()
gets used by default.This PR ensures the
SaveCredentialsRequestHandler
parses this date as UTC, by setting "UTC" as the parser's timezone.Before
After
📎 References
Fixes #160
🎯 Testing
Asserts were added to an existing unit test.