Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and gitignore pubspec.lock files #340

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 9, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

The auth0_flutter package includes /pubspec.lock in its .gitignore. However, the .gitignore of the auth0_flutter_platform_interface package does not.
Yet both pubspec.lock files are present in the repository.

This causes the following warning when publishing auth0_flutter:

Screenshot 2023-11-08 at 17 20 54 copy

Given that:

This PR removes both pubspec.lock files, and adds /pubspec.lock to the .gitignore of auth0_flutter_platform_interface package. And also adds **/doc/api to it.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (f2030d9) 90.31%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #340      +/-   ##
============================================
- Coverage     96.08%   90.31%   -5.78%     
============================================
  Files            97       49      -48     
  Lines          1611      475    -1136     
  Branches        331        0     -331     
============================================
- Hits           1548      429    -1119     
+ Misses           49       46       -3     
+ Partials         14        0      -14     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android ?
auth0_flutter_ios ?
auth0_flutter_platform_interface 87.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lib/src/web/extensions/user_profile_extension.dart 100.00% <100.00%> (ø)
...lutter_platform_interface/lib/src/credentials.dart 100.00% <100.00%> (ø)

... and 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket enabled auto-merge (squash) November 10, 2023 10:37
@Widcket Widcket merged commit 0402f0d into main Nov 10, 2023
14 of 15 checks passed
@Widcket Widcket deleted the chore/remove-lockfiles branch November 10, 2023 10:45
This was referenced Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants