change compileSdkVersion from 31 to flutter default #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
To overcome a bug in flutter flutter/flutter#63533 that sets the android sdk version to the lowest version used by any plugin, I am suggesting to update the android compileSdkVersion to the flutter default.
Without this, every project using your plugin ends up in compiling against android sdk 31
📎 References
flutter/flutter#63533
🎯 Testing
use auth0_flutter-1.7.2 and see it compiling against android sdk 31
use this fork and see it compiling against the current android sdk (34 or 35)