Callback with invalid token error when resuming transaction instead of throwing it

[dafortune]

Resume is async so it is better to callback with a documented exception when
the token is not valid.

[fiddur]

I think the nested try-blocks are an unnecessary complexity; couldn't this be handled in the same catch as the rest? If there are more exceptions possible, just check for error name if it should be transformed?

[fiddur]

Unfortunately there is no error name to check, it is just an instance of error, the only thing I can check is the message

That is awful :'(

I made a PR to add an InvalidTokenError, but it's ok if you don't want to wait for that.
auth0/jwt-decode#48

[dafortune]

Unfortunately there is no error name to check, it is just an instance of error, the only thing I can check is the message, but that seems worse to me El 17 mar. 2017 4:43 a. m., "Fredrik Liljegren" <notifications@github.com> escribió:

…

***@***.**** commented on this pull request. ------------------------------ In lib/index.js <#29 (comment)> : > - // create httpClient/socketClient - var httpClientInstance = object.get(options, 'dependencies.httpClient', - httpClient(transactionState.baseUrl, txId)); + try { + transactionTokenObject = jwtToken(transactionState.transactionToken); + } catch (e) { + throw new errors.InvalidToken('Invalid transaction token'); I think the nested try-blocks are an unnecessary complexity; couldn't this be handled in the same catch as the rest? If there are more exceptions possible, just check for error name if it should be transformed? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF7B23WCr24hh_aN-thfsiU7aafN5Mbjks5rmjmVgaJpZM4MgCFi> .