Support pagination on the Clients entity #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
reviewed
Jun 4, 2018
| @@ -8,7 +8,7 @@ | |||
| import java.util.List; | |||
|
|
|||
| /** | |||
| * Class that represents a Page of Auth0 Events objects. Related to the {@link com.auth0.client.mgmt.LogEventsEntity} entity. | |||
| * Class that represents a given Page of Log Events. Related to the {@link com.auth0.client.mgmt.LogEventsEntity} entity. | |||
There was a problem hiding this comment.
I accept the page change, but LogEvents is the name of the class that's why I capitalized it. Should I reference the class with a @link annotation instead?
| @@ -8,7 +8,7 @@ | |||
| import java.util.List; | |||
|
|
|||
| /** | |||
| * Class that represents an Auth0 User object. Related to the {@link com.auth0.client.mgmt.UsersEntity} entity. | |||
| * Class that represents a given Page of Users. Related to the {@link com.auth0.client.mgmt.UsersEntity} entity. | |||
| } | ||
|
|
||
| @Override | ||
| public ClientFilter withFields(String fields, boolean includeFields) { |
There was a problem hiding this comment.
What is the point of this logical? If you pick fields surely you would want to include them? Otherwise why include them?
There was a problem hiding this comment.
@cocojoe a Client has a huge number of properties. The endpoint accepts a fields value so you can filter them. When you pass a list of fields, you can also say whether you want those fields included (whitelist) or excluded (blacklist) from the response.
There was a problem hiding this comment.
ah ok, that makes more sense, I miss interpreted it 👍
lbalmaceda
force-pushed
the
some-pagination
branch
from
2eea644 to
2b8f849
Compare
lbalmaceda
force-pushed
the
some-pagination
branch
from
2b8f849 to
3f05fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way "Page Deserializers" work to prepare them for a generic approach. It also adds a ClientFilter and a new
list(filter)under the clients entity to send pagination parameters, among others.A separate PR will deprecate the existing
list()method, once this one is merged so it can reference the new one.