-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Core Authorization's User Roles and Permissions #193
Add support for Core Authorization's User Roles and Permissions #193
Conversation
@jakbutler thanks for taking care of this. I've added a review task to the backlog and I hope I can start with it the next week. |
…ge roles and permissions for users
be4f113
to
eddfd60
Compare
Apologies, I'd forgotten to also update the |
Terrific work @jakbutler ! I was just researching how we could use the Roles API and found out it was missing. A very nice surprise to see this PR. I can't wait until a new release is being made with this feature added. I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🎉
I've left some comments. Some of them are repetitive, e.g. wrong formatting of java docs, methods to request all items vs paginated, etc. Know I've skipped reviewing tests and json files for now. This is a first pass. You'll probably end up deleting 1/4 of the diff introduced. I'll hold to that for completing the review 👍
d788ab1
to
107ca68
Compare
376af32
to
ca2877c
Compare
e3f5be8
to
487f665
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes
RolesEntity
for providing access to the Role management API endpoints.Role
,Permission
,RolesPage
, andPermissionPage
value objects, with respective deserializers.RolesFilter
for use in the get_roles call.PageFilter
for specifying filter objects that only contain pagination options, e.g.per_page
andinclude_totals
.UserEntity
to include User Permission and User Role endpoints.References
Feature Request #192
Testing
Checklist