Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Core Authorization's User Roles and Permissions #193

Merged
merged 11 commits into from
Apr 23, 2019

Conversation

jakbutler
Copy link
Contributor

@jakbutler jakbutler commented Mar 26, 2019

Changes

  • Added a new RolesEntity for providing access to the Role management API endpoints.
  • Added supporting Role, Permission, RolesPage, and PermissionPage value objects, with respective deserializers.
  • Added a RolesFilter for use in the get_roles call.
  • Added a simple PageFilter for specifying filter objects that only contain pagination options, e.g. per_page and include_totals.
  • Updated UserEntity to include User Permission and User Role endpoints.

References

Feature Request #192

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@lbalmaceda
Copy link
Contributor

@jakbutler thanks for taking care of this. I've added a review task to the backlog and I hope I can start with it the next week.

@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from be4f113 to eddfd60 Compare March 28, 2019 15:38
@jakbutler
Copy link
Contributor Author

Apologies, I'd forgotten to also update the README.md to mention the Roles entity; that's been added now.

@martijnblankestijn
Copy link

Terrific work @jakbutler ! I was just researching how we could use the Roles API and found out it was missing. A very nice surprise to see this PR. I can't wait until a new release is being made with this feature added. I

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🎉
I've left some comments. Some of them are repetitive, e.g. wrong formatting of java docs, methods to request all items vs paginated, etc. Know I've skipped reviewing tests and json files for now. This is a first pass. You'll probably end up deleting 1/4 of the diff introduced. I'll hold to that for completing the review 👍

README.md Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/RolesEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/RolesEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/RolesEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/RolesEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/UsersEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/UsersEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/UsersEntity.java Outdated Show resolved Hide resolved
src/main/java/com/auth0/client/mgmt/filter/PageFilter.java Outdated Show resolved Hide resolved
jakbutler pushed a commit to jakbutler/auth0-java that referenced this pull request Apr 17, 2019
@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from d788ab1 to 107ca68 Compare April 17, 2019 22:25
@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from 376af32 to ca2877c Compare April 17, 2019 22:46
@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from e3f5be8 to 487f665 Compare April 23, 2019 14:27
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lbalmaceda lbalmaceda added this to the v1-Next milestone Apr 23, 2019
@lbalmaceda lbalmaceda changed the title Issue #192: Support for Core Authorization's User Roles and Permissions Add support for Core Authorization's User Roles and Permissions Apr 23, 2019
@lbalmaceda lbalmaceda merged commit d3c24db into auth0:master Apr 23, 2019
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.13.0 Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants