Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #198: Core Authorization fails when adding Roles to User #199

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Fix for issue #198: Core Authorization fails when adding Roles to User #199

merged 1 commit into from
Apr 25, 2019

Conversation

jakbutler
Copy link
Contributor

This is to resolve the problem described in issue #198.

Changes

  • Update to the removeRoles and addRoles methods of the UsersEntity class to accept a list of strings instead of a list of roles.
  • Update to the UsersEntityTest to correctly invoke the updated methods.

References

Issue #198

Testing

  • This change updates test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@cs-jackb
Fix for issue auth0#198; build the request body for adding roles to a…
b444ec2 
… user using only role id strings, not the whole Role object.
@lbalmaceda lbalmaceda merged commit 3e6f295 into auth0:master Apr 25, 2019
@lbalmaceda lbalmaceda added this to the 1.13.1 milestone Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jakbutler @lbalmaceda @cs-jackb