Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing property last_password_reset #256

Merged
merged 5 commits into from May 18, 2020
Merged

Add missing property last_password_reset #256

merged 5 commits into from May 18, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 14, 2020

Changes

Adds a missing property last_password_reset to the User object.

References

N/A

Testing

Added test for the last_password_reset property

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@ghost ghost self-requested a review May 14, 2020 18:45
@ghost ghost changed the title Add Missing Property last_password_reset Add missing property last_password_reset May 14, 2020
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 thanks for this.
The code looks good, although I couldn't find docs for the User last_password_reset property. Where is this coming from?

@ghost
Copy link
Author

ghost commented May 15, 2020

Hi @lbalmaceda,

You can find the user profile structure here 🙂

Unfortunately, this property is not reflected on the swagger API docs. Don't know the reason. Probably someone forgot to update 🙂

@ghost ghost requested a review from lbalmaceda May 15, 2020 07:51
@lbalmaceda
Copy link
Contributor

Yup, API docs are what I was referring to. I'm raising this internally first to confirm the property. I'll come back with an answer in the next days.

@lbalmaceda lbalmaceda added this to the v1-Next milestone May 15, 2020
mario-moura-silva and others added 2 commits May 16, 2020 00:59
Co-authored-by: Luciano Balmaceda <balmacedaluciano@gmail.com>
@lbalmaceda lbalmaceda self-requested a review May 18, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant