Add support for identity field for email verification jobs and tickets #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Sep 22, 2020
src/main/java/com/auth0/json/mgmt/EmailVerificationIdentity.java
Outdated
Show resolved
Hide resolved
lbalmaceda
suggested changes
Sep 25, 2020
jimmyjames
force-pushed
the
secondary-email-verification
branch
from
c774839 to
e2859ff
Compare
jimmyjames
force-pushed
the
secondary-email-verification
branch
from
c9624cd to
66be7ab
Compare
lbalmaceda
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for specifying the (optional)
identityobject when creating email verification tickets or jobs. This is needed when verifying emails when the primary is social, enterprise, or passwordless. Also needed to verify secondary identities.References
Testing
In addition to unit tests, I've also verified the changes manually using a real tenant and users.
Checklist