Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to OkHttp 4 #319

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Update to OkHttp 4 #319

merged 1 commit into from
Nov 16, 2020

Conversation

jimmyjames
Copy link
Contributor

Changes

Updates the OkHttp dependency to version 4.

Details on the changes contained in version 4 can be found here (impacts are intentionally small).

I did change three usages of RequestBody.create to reverse the parameter order to resolve deprecation warnings, as documented by OkHttp.

References

Checklist

@jimmyjames jimmyjames added this to the v1-Next milestone Nov 12, 2020
@jimmyjames jimmyjames requested a review from a team as a code owner November 12, 2020 19:41
@jimmyjames jimmyjames merged commit b0f0640 into master Nov 16, 2020
@jimmyjames jimmyjames deleted the okhttp4 branch November 16, 2020 14:12
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.25.0 Nov 16, 2020
@jimmyjames jimmyjames mentioned this pull request Nov 16, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
CH: Changed review:small Small review
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjames @Widcket