Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-2537] Add missing parameters to Ticket entities #352

Merged
merged 2 commits into from
Apr 27, 2021
Merged

[SDK-2537] Add missing parameters to Ticket entities #352

merged 2 commits into from
Apr 27, 2021

Conversation

jimmyjames
Copy link
Contributor

Changes

Adds missing body parameters to create an email verification ticket and to create a password change ticket.

The following fields were added to the EmailVerificationTicket entity:

  • client_id
  • organization_id

The following fields were added to the PasswordChangeTicket entity:

  • client_id
  • includeEmailInRedirect

This resolves #351

@jimmyjames jimmyjames added this to the v1-Next milestone Apr 22, 2021
@jimmyjames jimmyjames requested a review from a team as a code owner April 22, 2021 17:46
adamjmcgrath
adamjmcgrath previously approved these changes Apr 27, 2021
View reviewed changes
@adamjmcgrath adamjmcgrath self-requested a review April 27, 2021 16:56
@jimmyjames jimmyjames merged commit f349b31 into master Apr 27, 2021
@lbalmaceda lbalmaceda deleted the add-missing-post-ticket-params branch April 28, 2021 07:46
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.30.0 Apr 28, 2021
@jimmyjames jimmyjames mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
CH: Added review:small Small review
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.

Missing body options in requesting password change ticket
2 participants
@jimmyjames @adamjmcgrath