Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warning for untyped requests #385

Conversation

pelletier197
Copy link
Contributor

@pelletier197 pelletier197 commented Oct 28, 2021

Changes

Please describe both what is changing and why this is important. Include:

I Added specific typing for void requests. This is important because first, IDEs usually give warnings when an object's type is not specified. It does not do anything at runtime because of type-erasure, but it makes it impossible for the IDE to know what is supposed to come out of that object.

image

This causes a small inconvenience when using the library. In my case, I wrapped the auth0 library with custom code that handles Rate-limiting better and automatically execute requests, which is why the dynamic typing is needed.

image

I was therefore forced to specify myself the Any type (because the library doesn't specify the Void)

image

Testing

Does not impact tests. It just removes warnings.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@pelletier197 pelletier197 requested a review from a team as a code owner October 28, 2021 14:46
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice work! Thanks for this contribution!!

@jimmyjames jimmyjames merged commit 19c711b into auth0:master Dec 2, 2021
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.36.0 Jan 10, 2022
@jimmyjames jimmyjames mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants