Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate setLoggingEnabled on API clients #396

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Deprecate setLoggingEnabled on API clients #396

merged 1 commit into from
Jan 20, 2022

Conversation

jimmyjames
Copy link
Contributor

Follow-up to the changes introduced in #392, this change deprecates the setLoggingEnabled(Boolean enabled) in favor of configuring the HTTP logging via the HttpOptions when building the client.

@jimmyjames jimmyjames added this to the v1-Next milestone Jan 20, 2022
@jimmyjames jimmyjames requested a review from a team as a code owner January 20, 2022 18:05
@jimmyjames jimmyjames merged commit 5211476 into master Jan 20, 2022
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.37.0 Jan 20, 2022
@jimmyjames jimmyjames mentioned this pull request Jan 20, 2022
Merged
@evansims evansims deleted the deprecate-mutable-logging branch July 5, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
CH: Deprecated review:tiny Tiny review
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmyjames @evansims