Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabled connections on organization #426

Merged

Conversation

charliearaya
Copy link

@charliearaya charliearaya commented May 17, 2022

Changes

This PR adds the possibility to set Enabled Connections on an Organization on create, which so far could only be done after creating the organization and only one connection at a time. Changes:

  • Added enabled_connections property on Organization
  • Fixed tests to include enabled_connections

References

#425
https://auth0.com/changelog#6BBzbWOwkhEZdzauu2s0Bg

Testing

This can be tested by adding enabled connections when creating an organization. I have modified some tests to check for enabled_connections. I have not added tests specific to enabled_connections, I have only modified shouldCreateOrganization, shouldSerialize and shouldDeserialize.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@charliearaya charliearaya requested a review from a team as a code owner May 17, 2022 07:05
@poovamraj
Copy link
Contributor

Hey @charliearaya, I checked it out and all looks good. Thanks a lot for contributing 👍

@poovamraj poovamraj closed this May 17, 2022
@poovamraj poovamraj reopened this May 17, 2022
@poovamraj poovamraj merged commit d3236c2 into auth0:master May 18, 2022
@poovamraj poovamraj added this to the v1-Next milestone May 19, 2022
@charliearaya charliearaya deleted the add_enabled_connections_on_organization branch May 19, 2022 14:10
@poovamraj poovamraj modified the milestones: v1-Next, 1.42.0 May 20, 2022
@poovamraj poovamraj mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants