Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure version is defined before plugins are applied #439

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

frederikprijck
Copy link
Member

Changes

This PR ensures the version property is defined before the plugins are applied, to ensure we can use it in the LibraryPlugin's apply method.

References

auth0/oss-library-gradle-plugin#32

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@frederikprijck frederikprijck marked this pull request as ready for review June 23, 2022 12:59
@frederikprijck frederikprijck requested a review from a team as a code owner June 23, 2022 12:59
@frederikprijck frederikprijck marked this pull request as draft June 23, 2022 14:23
@frederikprijck frederikprijck marked this pull request as ready for review June 24, 2022 14:24
@frederikprijck frederikprijck merged commit 757f1bf into master Jun 24, 2022
@jimmyjames jimmyjames mentioned this pull request Sep 19, 2022
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.43.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants