Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requests dependency to latest version #196

Merged
merged 1 commit into from
May 31, 2019
Merged

Update requests dependency to latest version #196

merged 1 commit into from
May 31, 2019

Conversation

lbalmaceda
Copy link
Contributor

Changes

This PR bumps the requests version required by the SDK. Now instead of requiring a fix version, it's only required a minimum.

I'd release this on a new minor (not patch).

Testing

Did not need to change the tests, all pass fine.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added the tiny Tiny review label May 31, 2019
@lbalmaceda lbalmaceda added this to the v3-Next milestone May 31, 2019
@lbalmaceda lbalmaceda requested review from damieng and a team May 31, 2019 19:51
@damieng damieng merged commit b08bac8 into master May 31, 2019
@damieng damieng deleted the bump-requests branch May 31, 2019 21:11
@lbalmaceda lbalmaceda modified the milestones: v3-Next, 3.8.0 Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Security tiny Tiny review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @damieng