Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3173] Default to 'None' for deployed on GET /api/v2/actions/actions endpoint #309

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented Mar 9, 2022

Changes

For the GET /api/v2/actions/actions endpoint, we currently (incorrectly) default the deployed parameter to False instead of None. This means we only return results containing actions that haven't been deployed. The API supports and defaults to this being unset, so all action types are returned, as one would expect.

This PR changes the parameter default from False to None to return all actions without a deployment filter applied, as would be expected, default behavior.

References

Testing

  • Tests have been updated to capture regression potential, and to cover the new None default state of the parameter.
  • Run coverage run --m unittest discover to try these updated tests, or review CircleCI logs.

Checklist

@evansims evansims requested a review from a team as a code owner March 9, 2022 21:42
@adamjmcgrath adamjmcgrath merged commit 719bc9e into master Mar 10, 2022
@adamjmcgrath adamjmcgrath deleted the sdk-3173/fix-get_actions branch March 10, 2022 16:28
@adamjmcgrath adamjmcgrath added this to the 3.22.0 milestone Mar 22, 2022
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using v3.19.0 unable to return all actions
2 participants