Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async auth client #499

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix async auth client #499

merged 2 commits into from
Jun 26, 2023

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Jun 22, 2023

Changes

Asyncifying authentication classes doesn't work because the asyncify method was assuming the wrong signature.

References

fixes #498

Testing

AsyncGetToken = asyncify(GetToken)

get_token = AsyncGetToken(domain, client_id)

response = await self.get_token.login_async(
    username=username,
    password=password,
    realm="Username-Password-Authentication",
    scope="openid profile email",
)

Checklist

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner June 22, 2023 12:38
@adamjmcgrath adamjmcgrath added the review:small Small review label Jun 22, 2023
@adamjmcgrath adamjmcgrath merged commit 0bf0176 into master Jun 26, 2023
4 checks passed
@adamjmcgrath adamjmcgrath deleted the fix-async-auth branch June 26, 2023 14:30
@adamjmcgrath adamjmcgrath mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetToken and asyncify: Algorithm not supported
2 participants