Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rest_async and async tests #556

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Fix rest_async and async tests #556

merged 6 commits into from
Nov 28, 2023

Conversation

adamjmcgrath
Copy link
Contributor

Changes

Broke rest_sync in #518 and an issue in the async tests meant it didn't get picked up.

References

fixes #555

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner November 22, 2023 12:22
@adamjmcgrath adamjmcgrath mentioned this pull request Nov 22, 2023
Closed
5 tasks
@adamjmcgrath adamjmcgrath reopened this Nov 22, 2023
@adamjmcgrath adamjmcgrath reopened this Nov 22, 2023
@adamjmcgrath adamjmcgrath reopened this Nov 22, 2023
@adamjmcgrath
Copy link
Contributor Author

adamjmcgrath commented Nov 22, 2023 •
edited
Loading

Updated the action to fix 3.7, but "Build and Test / Run (3.7)" uses the action from master (so need to merge it to master to update the action...)

(And 3.10 was canceled because "_3_7" failed.)

@adamjmcgrath adamjmcgrath merged commit 7625804 into master Nov 28, 2023
10 of 12 checks passed
@adamjmcgrath adamjmcgrath deleted the fix-async branch November 28, 2023 10:20
@adamjmcgrath adamjmcgrath mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting an error coroutine 'AsyncRestClient._request_with_session' was never awaited
2 participants
@adamjmcgrath @ewanharris