Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing invalid state errors with Generic Error #1102

Merged
merged 1 commit into from
May 30, 2023
Merged

Fix missing invalid state errors with Generic Error #1102

merged 1 commit into from
May 30, 2023

Conversation

frederikprijck
Copy link
Member

Changes

I missed two occurences with #1099 . This PR adds a backwards compatible Generic Error with the same message instead of an Error.

References

closes #1101

Testing

  • This change adds unit test coverage
  • [ x This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner May 30, 2023 08:53
@frederikprijck frederikprijck merged commit 0fdb6b6 into master May 30, 2023
@frederikprijck frederikprijck deleted the fix/1101 branch May 30, 2023 09:00
@frederikprijck frederikprijck mentioned this pull request May 30, 2023
Merged
@gardnern gardnern mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missed Invalid state errors with Generic Error
2 participants
@frederikprijck @adamjmcgrath