Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure organization cookie is set when no organization was set #1123

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Ensure organization cookie is set when no organization was set #1123

merged 1 commit into from
Aug 18, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 18, 2023 •
edited
Loading

Changes

Code was incorrectly changed in #1113 that resulted in the cookie for organization to no longer be set when:

  • No organization was set in the SDK
  • But the user did log in to an Organization in Auth0.

This PR ensures we fallback to the claim when no organization was specified.

References

auth0/auth0-angular#465

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner August 18, 2023 11:20
@frederikprijck frederikprijck enabled auto-merge (squash) August 18, 2023 11:23
@frederikprijck frederikprijck merged commit 96433b6 into master Aug 18, 2023
5 checks passed
@frederikprijck frederikprijck deleted the fix/org_cookie branch August 18, 2023 12:21
@frederikprijck frederikprijck mentioned this pull request Aug 21, 2023
Merged
@gardnern gardnern mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @adamjmcgrath