Add implicit return

[sanvisser]

Changes

• I added an explicit return for the case where both if-statements evaluate to false. This explicit return of undefined does not change the current behavior, so I do not think any additional test coverage is necessary.

Recording.2024-07-09.121631.mp4

References

• fixes Implicit return in auth0-spa-js/src/cache /cache-manager.ts when TS "noImplicitReturns" is set to true #1280

Testing

- [ ] This change adds unit test coverage
- [ ] This change adds integration test coverage
- [ ] This change has been tested on the latest version of the platform/language

Checklist

• I have read the Auth0 general contribution guidelines
• I have read the Auth0 Code of Conduct
• All code quality tools/guidelines have been run/followed

[frederikprijck]

Thanks, we should be able to merge this with a few changes. But trying to understand one thing first ... Why should our TS compiler settings affect yours?

We have not set noImplicitReturns to true. Assuming that is done with reason, I'd expect this not to impact consuming projects that does set it to true as we ship js and d.ts files. Can you give some context?

In this case, I think setting noImplicitReturns to true and fix the problem makes sense. But I'd also argue it should not be needed. So I'd like to try and understand what's going on prior to merging this.

[frederikprijck]

I gave this a try in a project using typescript@5.3.2 and @auth0/auth0-spa-js@2.1.3 and have set "noImplicitReturns": true.I was able to include and use the SDK just fine without any compiler issue. Which was also concluded by @nandan-bhat here: #1280 (comment).

So I think we need a reproduction to investigate what is happening, rather than merge a PR that fixes something that we can not reproduce.

[sanvisser]

So the problem was on my end. I imported the file wrong. Using the normal import fixes the problem too without needing a noImplicitReturns workaround. my bad!