Add 'lock' to prevent getTokenSilently
to be invoked in parallel
#238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, the
getTokenSilently
method behaves like this:The problem we have today is that if you call the method concurrently, we can hit a race condition where, by having two iframes at the same time, the order of the response is mixed and by the time you try to remove the iframe, it’s already gone and it throws an error (#109).
This PR implements a 'lock' the current instance of the Auth0Client in all instances of your app (from the same browser) until the
getTokenSilently
call is finished. This enables us to always* execute the method once at a time.References
fix #109
Testing