-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use user provided params on silent login #318
Conversation
@nkete Thanks for raising this. Before we bring it in, let me get a look at that integration test which is being skipped and get back to you. You're right, we'll want to update that with your changes if we can. |
@nkete I'm doing some other work on this SDK and in there I've ended up removing the integration test that is being skipped. It was being skipped because it just doesn't work, so I've removed it and taken a different approach. However, it's only available in another branch so I would ignore this test for now. However, we would require some unit test coverage around this new functionality you've provided - could you please add those tests to the PR? |
@stevehobbsdev sure, I'll get back to you once I add the tests. |
Thanks @nkete. To clarify above, when I mentioned "test coverage" I was referring to unit tests. I'd think they'd be enough for this particular case. |
dc250a4
to
a757195
Compare
@stevehobbsdev I added a test for custom params to the |
a757195
to
b0d302d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. I've scheduled it for release, just waiting on a couple of other things coming in before that happens. Thanks!
Description
This PR adds support for custom query parameters in
getTokenSilently
similar to howloginWithRedirect
does this.References
Testing
Add a custom property to the
getTokenSilently
method call and inspect the generated url.I was looking at integration tests I noticed that
getTokenSilently > Builds URL correctly
test is skipped. Can someone provide some context on why is that? Should the test be updated to reflect custom parameters as well?Checklist