[SDK-1395] Refactor loginWithPopup to optionally accept an existing popup window

[stevehobbsdev]

Description

This PR adds a new option to loginWithPopup that would allow the developer to pass an existing popup window to be used instead of the SDK creating its own. This allows the popup to work better in scenarios like on iOS where the popup should be opened inside a button click handler without any async wrappers.

It also allows us to fix an issue where the popup sometimes doesn't work properly inside a PWA. The existing logic creates the pop window and then sets the URL, whereas now in this PR those two steps are unified.

References

Closes #300

Testing

Manually tested by adding a new button to the playground that allows a popup window to be specified when calling loginWithPopup. Unit tests have also been added.

• This change adds test coverage for new/changed/fixed functionality

Checklist

• I have added documentation for new/changed functionality in this PR or in auth0.com/docs
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not master

[zewa666]

worked for me on Android, had no opportunity to test on iOS due to lack of device. But since @charsleysa mentioned doing it this way in his patch I would guess it should work as well.

[stevehobbsdev]

@zewa666 Thanks for looking. Can you confirm that it solves your original problem of opening the popup window without the need for a setTimeout call?

[zewa666]

@stevehobbsdev sorry for being unclear. Yes I've reverted my changes, checked out your branch in my cloned repo, ran npm run build and tried it on the phone. It did pass for me

[stevehobbsdev]

Thanks @zewa666 !

[charsleysa]

LGTM