Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include mocks in build #503

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Don't include mocks in build #503

merged 2 commits into from
Jun 12, 2020

Conversation

adamjmcgrath
Copy link
Contributor

Description

We don't need to include __mocks__ in the output build. It also breaks ts when using typeRoots

References

Fixes #498

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added tiny CH: Fixed PR is fixing a bug labels Jun 12, 2020
@adamjmcgrath adamjmcgrath requested a review from a team June 12, 2020 09:28
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jun 12, 2020
@adamjmcgrath adamjmcgrath merged commit 44cba7e into master Jun 12, 2020
@adamjmcgrath adamjmcgrath deleted the remove_mocks_from_ts branch June 15, 2020 11:00
@adamjmcgrath adamjmcgrath restored the remove_mocks_from_ts branch June 15, 2020 11:00
@adamjmcgrath adamjmcgrath deleted the remove_mocks_from_ts branch June 15, 2020 11:00
@stevehobbsdev stevehobbsdev added review:tiny Tiny review and removed tiny labels Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug review:tiny Tiny review
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Typings issue when using typeRoots instead of explict type import
2 participants
@adamjmcgrath @stevehobbsdev