[SDK-1789] Add custom initial options to the 2 getToken methods #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjmcgrath
changed the title
stevehobbsdev
approved these changes
Jul 13, 2020
| @@ -719,6 +747,7 @@ export default class Auth0Client { | |||
|
|
|||
| const tokenResult = await oauthToken( | |||
| { | |||
| ...this.customOptions, | |||
| ...customOptions, | |||
There was a problem hiding this comment.
I wonder if it's worth renaming the local customOptions here, alongside this.customOptions, it could be confusing as to why they're both there. Or do you feel the reference to this is enough to differentiate them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Custom auth params that are declared in the constructor should be passed to the token endpoint for the 2 get token methods (iframe and code exchange and refresh token)
References
fixes #514
Testing
Checklist
master