Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-2037] Remove cacheLocation guard from checkSession #613

Merged
merged 3 commits into from
Oct 29, 2020
Merged

[SDK-2037] Remove cacheLocation guard from checkSession #613

merged 3 commits into from
Oct 29, 2020

Conversation

frederikprijck
Copy link
Member

Remove cacheLocation guard from checkSession to ensure the cookie value is always used to determine whether or not a session call should occur.

@frederikprijck frederikprijck requested a review from a team as a code owner October 28, 2020 15:40
adamjmcgrath
adamjmcgrath approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that was easier than I thought it would be

@adamjmcgrath
Copy link
Contributor

Fixes auth0/auth0-react/issues/124

@frederikprijck frederikprijck added the CH: Changed PR is changing something label Oct 28, 2020
@frederikprijck frederikprijck added this to the vNext milestone Oct 28, 2020
@frederikprijck frederikprijck merged commit 185ffba into master Oct 29, 2020
@frederikprijck frederikprijck deleted the frederik/SDK-2037 branch October 29, 2020 09:48
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
CH: Changed PR is changing something
Projects
None yet
Milestone
v1.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @adamjmcgrath