Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send useCookiesForTransactions to authorize request #673

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 14, 2020

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

useCookiesForTransactions was being sent to the /authorize endpoint which seems like not intended.

This appears to be a common thing, because we rely on allowing any additional parameters to be sent to /authorize, as soon as we start adding additional configurations (for client side use only), they end up being sent to the /authorize endpoint anyway.

We talked about this before, but I guess the SDK would benefit from having the configuration options reconsidered and restructured.

References

auth0/auth0-react#170

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@frederikprijck frederikprijck requested a review from a team as a code owner December 14, 2020 09:54
@frederikprijck frederikprijck added the review:tiny Tiny review label Dec 14, 2020
@stevehobbsdev
Copy link
Contributor

@frederikprijck agreed that this isn't exactly scalable. If we could restructure the API, we can solve this problem. I've kept a note internally.

@frederikprijck frederikprijck merged commit 9f313c9 into master Dec 14, 2020
@frederikprijck frederikprijck deleted the fix/use-cookies-for-transactions branch December 14, 2020 19:16
@stevehobbsdev stevehobbsdev added the CH: Changed PR is changing something label Jan 7, 2021
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jan 7, 2021
@stevehobbsdev stevehobbsdev mentioned this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Changed PR is changing something review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants