Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated minor syntax, to allow for TypeScript compiler to be happier #714

Merged
merged 5 commits into from
Mar 8, 2021

Conversation

kachihro
Copy link
Contributor

@kachihro kachihro commented Mar 3, 2021

Description

Have logged an issue, and then investigated within source code ;
#713

Fix #1 : to return a specific type, Promise, which then includes a reference in IMPORTS - to avoid an 'include' statement within TYPINGS

Fix #2 : no need for additional reference (= USER) - this causes a 'missing comma' error in TypeScript compiler (!?!)

Testing

No functionality change, simply to provide for more succinct and precise code - when compiling with TypeScript 2.2.2
(This is needed for a SharePoint SPFX webpart being created)

Checklist

  • [ X ] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
    (No changed functionality)

  • [ X ] All active GitHub checks for tests, formatting, and security are passing

  • [ X ] The correct base branch is being used, if not master

@kachihro kachihro requested a review from a team as a code owner March 3, 2021 11:48
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Mar 3, 2021

This pull request introduces 1 alert when merging edb7390 into be9e9d7 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@frederikprijck frederikprijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks like this introduces an unused import so we might want to fix that so that the code is actually using the imported IdToken.

src/Auth0Client.ts Outdated Show resolved Hide resolved
@stevehobbsdev stevehobbsdev added this to the vNext milestone Mar 8, 2021
@stevehobbsdev stevehobbsdev added CH: Fixed PR is fixing a bug review:small Small review labels Mar 8, 2021
@stevehobbsdev stevehobbsdev linked an issue Mar 8, 2021 that may be closed by this pull request
@stevehobbsdev stevehobbsdev merged commit 64b3cbd into auth0:master Mar 8, 2021
@stevehobbsdev stevehobbsdev mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed PR is fixing a bug review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dist\typings causing compile error with TypeScript
3 participants