-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2677] Support node-oidc-provider #768
Conversation
This pull request introduces 1 alert when merging 66a12fe into 30e674c - view on LGTM.com new alerts:
|
Marked as draft as I want to do a little more testing. |
This pull request introduces 1 alert when merging 5227c26 into 30e674c - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small question.
This pull request introduces 1 alert when merging 6740c33 into 30e674c - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 15fb94c into 30e674c - view on LGTM.com new alerts:
|
Description
This PR adds support for using node-oidc-provider in the playground as an alternative for hitting real Auth0. The motivation is that, in another PR that's coming, we can add support for running E2E tests against this provider instead of Auth0. Additionally, we can run the auth server on the same origin as the application being tested, and avoid cross-origin issues when using Cypress.
To make this work, a number of things had to be changed:
rollup-plugin-serve
, as the former has better extensibility points and proxy support (should we need it)node-oidc-provider
into the application by providing the appropriate mount points to the underlying Koa app that is created byrollup-plugin-dev
. This means that the auth server can run on the same origin as the apphttp
orhttps
scheme, and will not try to automatically prefix withhttps
. This allows us to usehttp://localhost:3000
as the domain when using the OIDC providernode-oidc-provider
only supports form data on the token endpoint (as per the spec), this PR also adds a new config optionuseFormData
to the SDK where the developer can opt-in to using form data instead of JSON. We'd like to move to using this as the default later, as it's faster (no CORS pre-flight check)Summary