Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(Auth0Client):added cookieDomain to _processOrgIdHint #900

Merged
merged 1 commit into from
May 6, 2022
Merged

update(Auth0Client):added cookieDomain to _processOrgIdHint #900

merged 1 commit into from
May 6, 2022

Conversation

Dannnir
Copy link
Contributor

@Dannnir Dannnir commented Apr 26, 2022

Changes

added cookieDomain configuration to OrgId cookie hint

References

#885

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@Dannnir Dannnir requested a review from a team as a code owner April 26, 2022 16:21
@stevehobbsdev
Copy link
Contributor

Looks good, thanks for the contribution. If you can add unit tests around this I'd be happy to review and approve.

@Dannnir
Copy link
Contributor Author

Dannnir commented Apr 27, 2022

Thanks @stevehobbsdev, done

@Dannnir
Copy link
Contributor Author

Dannnir commented May 2, 2022

@stevehobbsdev

@stevehobbsdev
Copy link
Contributor

Thanks for the contribution!

@stevehobbsdev stevehobbsdev merged commit 36b1cd2 into auth0:master May 6, 2022
@Dannnir Dannnir deleted the patch-1 branch May 8, 2022 11:23
@Dannnir
Copy link
Contributor Author

Dannnir commented May 8, 2022

@stevehobbsdev Can we push a new release tag for this one?

@stevehobbsdev
Copy link
Contributor

Yes, a new release will be pushed out next week.

@stevehobbsdev stevehobbsdev mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dannnir @stevehobbsdev