Fix unit tests by stubbing RSA verification #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
approved these changes
Mar 11, 2020
stevehobbsdev
pushed a commit
that referenced
this pull request
Apr 9, 2020
* Applied #1085 from auth0.js (fixes broken tests) * Added an object helper for setting properties at a deep level * Masking password in original error object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, the unit tests use
idtoken-verifierto verify ID tokens, including downloading the JWKS document to verify the RS256 signature.This PR stubs that call out to always return
truefor RSA verification (the tests assumed true anyway), but it does make the tests more robust and unaffected by signing key changes on the server.References
Instigated by this failing test suite.
Testing
No test coverage added, just changes to setup/teardown for the
parseHashtests.Checklist