Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Passwordless Verify #1202

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

seanaye
Copy link
Contributor

@seanaye seanaye commented Aug 25, 2021

This PR addresses the issue detailed here: auth0/lock#2027 by adding the clientID to outgoing requests to passwordless/verify

@seanaye seanaye requested a review from a team as a code owner August 25, 2021 13:58
@seanaye seanaye changed the title Add clientID to passwordless verify requests Fix: Passwordless Verify Aug 25, 2021
@stevehobbsdev stevehobbsdev added this to the vNext milestone Aug 25, 2021
@stevehobbsdev
Copy link
Contributor

Thanks @seanaye. I'm just looking deeper at the circumstances around why you're getting this error in the first place and why we haven't heard more about it. I can't reproduce this in my own environment - I can go through the entire passwordless flow without it sending client_id and I don't get this error. It's clear from the docs that such a parameter is required, but seems like it's only required sometimes.

It's worth exploring because I think there are other changes to make beyond just the change in this PR - none of the code around this method suggests that a client ID should be supplied and it's certainly not enforced by the options validator.

However, it's a faily innocuous change at the moment so happy to merge and I'll fill in the rest of that later. Again, thanks for raising 👍🏻

@stevehobbsdev
Copy link
Contributor

There are some unit tests failing as none of them expect this parameter - I'll will update those first.

@stevehobbsdev stevehobbsdev merged commit 778255e into auth0:master Aug 26, 2021
@stevehobbsdev stevehobbsdev mentioned this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants