Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IAMRISK-2915] Added support for Auth0 v2 captcha provider #1368

Merged
merged 3 commits into from
Dec 13, 2023
Merged

[IAMRISK-2915] Added support for Auth0 v2 captcha provider #1368

merged 3 commits into from
Dec 13, 2023

Conversation

alexkoumarianos-okta
Copy link
Contributor

@alexkoumarianos-okta alexkoumarianos-okta commented Dec 11, 2023 •
edited
Loading

Changes

Added support for Auth0 v2 (Cloudflare turnstile) captcha provider.

References

https://auth0team.atlassian.net/browse/IAMRISK-2915

Testing

tested locally with server:
Screenshot 2023-12-11 at 1 07 25 PM
Screenshot 2023-12-11 at 1 07 09 PM

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@alexkoumarianos-okta alexkoumarianos-okta requested a review from a team as a code owner December 11, 2023 14:57
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2023
View reviewed changes
test/web-auth/captcha.test.js Fixed Show fixed Hide fixed
test/web-auth/captcha.test.js Fixed Show fixed Hide fixed
frederikprijck
frederikprijck reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@frederikprijck frederikprijck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will review as soon as possible .

Is there a reason we have named all captcha's based on the implementation (hcaptcha, arkose, friendly), while now we are using turnstile and name it auth0 v2?

@alexkoumarianos-okta
Copy link
Contributor Author

Is there a reason we have named all captcha's based on the implementation (hcaptcha, arkose, friendly), while now we are using turnstile and name it auth0 v2?

Yes, we are white-labeling this implementation so product wants us to use the naming auth0_v2 everywhere we can.

@frederikprijck frederikprijck enabled auto-merge (squash) December 13, 2023 10:21
@frederikprijck frederikprijck merged commit f5e1f71 into auth0:master Dec 13, 2023
16 checks passed
@alexkoumarianos-okta alexkoumarianos-okta changed the title [IAMRISK-2916] Added support for Auth0 v2 captcha provider [IAMRISK-2915] Added support for Auth0 v2 captcha provider Dec 13, 2023
@frederikprijck frederikprijck mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srijonsaha srijonsaha srijonsaha approved these changes

@TSLarson TSLarson TSLarson approved these changes

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexkoumarianos-okta @frederikprijck @TSLarson @srijonsaha